build/android/buildbot/bb_device_steps.py - Issue 1315743004: [Android] Add a custom pylintrc for build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/buildbot/bb_device_steps.py

diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py

index 2e4c42efda56ef7bc5f751fa14599596e568971a..5fbd089a9fb65e4212116573df2938b9baccc449 100755

--- a/build/android/buildbot/bb_device_steps.py

+++ b/build/android/buildbot/bb_device_steps.py

@@ -517,7 +517,7 @@ def RunGPUTests(options):

EscapeBuilderName(builder_name)])

-def RunPythonUnitTests(_options):

+def RunPythonUnitTests(_options): # pylint: disable=unused-argument

for suite in constants.PYTHON_UNIT_TEST_SUITES:

bb_annotations.PrintNamedStep(suite)

RunCmd(['build/android/test_runner.py', 'python', '-s', suite])

@@ -724,6 +724,7 @@ def main(argv):

setattr(options, 'target', options.factory_properties.get('target', 'Debug'))

+ # pylint: disable=global-statement

if options.chrome_output_dir:

global CHROME_OUT_DIR

perezju 2015/09/04 09:01:53 Is there a reason why we really need this globals?

jbudorick 2015/09/04 16:51:55 No idea. These bb_* scripts are mostly unused with

perezju 2015/09/08 13:40:10 ok, sgtm

global LOGCAT_DIR

« no previous file with comments | « build/android/buildbot/bb_device_status_check.py ('k') | build/android/buildbot/bb_utils.py » ('j') | build/android/buildbot/bb_utils.py » ('J')