Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3024)

Unified Diff: content/renderer/render_view_impl.h

Issue 131573003: Convert DomAutomationController from CppBoundClass to gin::Wrappable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index f3c8958f5e9d83dc59a6ed4526b4cc1261bc277d..9a4aae3f0eb4247ea11ef1d312f0d89767678d05 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -1498,7 +1498,7 @@ class CONTENT_EXPORT RenderViewImpl
// Allows JS to access DOM automation. The JS object is only exposed when the
// DOM automation bindings are enabled.
Aaron Boodman 2014/01/09 20:11:06 How does RV lifetime relate to frame lifetime, and
Aaron Boodman 2014/01/09 20:19:20 On second thought, instead of storing this scary l
jochen (gone - plz use gerrit) 2014/01/09 20:30:38 I think I'll just install one controller per frame
- scoped_ptr<DomAutomationController> dom_automation_controller_;
+ DomAutomationController* dom_automation_controller_;
// This field stores drag/drop related info for the event that is currently
// being handled. If the current event results in starting a drag/drop

Powered by Google App Engine
This is Rietveld 408576698