Convert DomAutomationController from CppBoundClass to gin::Wrappable

content/renderer/render_view_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 1479 matching lines @@
   // State associated with the GetWindowSnapshot function.
   int next_snapshot_id_;
   typedef std::map<int, WindowSnapshotCallback> PendingSnapshotMap;
   PendingSnapshotMap pending_snapshots_;
 
   // Allows to selectively disable partial buffer swap for this renderer's
   // compositor.
   bool allow_partial_swap_;
 
   // Allows JS to access DOM automation. The JS object is only exposed when the
   // DOM automation bindings are enabled.

[Aaron Boodman, 2014/01/09 20:11:06]

How does RV lifetime relate to frame lifetime, and more specifically this
pointer? Can the JS context shut down making this pointer garbage while RV is
still outstanding?

Either way some comments would be good.

[Aaron Boodman, 2014/01/09 20:19:20]

On second thought, instead of storing this scary looking pointer, what about
stashing DomAutomatonController in JS-land instead, via
frame->context()->global()->SetHiddenValue()?

On the other hand, it looks like this pointer is never used except as a flag as
to whether the controller has been installed already. In that case, maybe we
shouldn't store it at all, but rather actually look in the JS context and see if
it's there. Or store a boolean did_install_ instead?

[jochen (gone - plz use gerrit), 2014/01/09 20:30:38]

I think I'll just install one controller per frame and don't keep a reference to
it at all

-  scoped_ptr<DomAutomationController> dom_automation_controller_;
+  DomAutomationController* dom_automation_controller_;
 
   // This field stores drag/drop related info for the event that is currently
   // being handled. If the current event results in starting a drag/drop
   // session, this info is sent to the browser along with other drag/drop info.
   DragEventSourceInfo possible_drag_event_info_;
 
   // NOTE: stats_collection_observer_ should be the last members because their
   // constructors call the AddObservers method of RenderViewImpl.
   scoped_ptr<StatsCollectionObserver> stats_collection_observer_;
 
   ui::MenuSourceType context_menu_source_type_;
   gfx::Point touch_editing_context_menu_location_;
 
   // ---------------------------------------------------------------------------
   // ADDING NEW DATA? Please see if it fits appropriately in one of the above
   // sections rather than throwing it randomly at the end. If you're adding a
   // bunch of stuff, you should probably create a helper class and put your
   // data and methods on that to avoid bloating RenderView more.  You can
   // use the Observer interface to filter IPC messages and receive frame change
   // notifications.
   // ---------------------------------------------------------------------------
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_