Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 1315663004: [bindings] Bindings should only support the prescribed types for constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp
index 6d31733a5fb9aca5328531cd60ca4d4aeb2886b9..405cc74d9d00fbceef939e338e9209f898dfd1a1 100644
--- a/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -12925,34 +12925,33 @@ static void installV8TestObjectTemplate(v8::Local<v8::FunctionTemplate> function
V8DOMConfiguration::installAccessor(isolate, instanceTemplate, prototypeTemplate, functionTemplate, defaultSignature, accessorConfiguration);
}
static const V8DOMConfiguration::ConstantConfiguration V8TestObjectConstants[] = {
- {"CONST_VALUE_0", 0, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_1", 1, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_2", 2, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_4", 4, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_8", 8, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_9", -1, 0, 0, V8DOMConfiguration::ConstantTypeShort},
- {"CONST_VALUE_10", 0, 0, "my constant string", V8DOMConfiguration::ConstantTypeString},
- {"CONST_VALUE_11", 0xffffffff, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_12", 0x01, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_13", 0X20, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_14", 0x1abc, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_15", 010, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_16", -010, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_16", -0x1A, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_17", -0X1a, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
- {"CONST_VALUE_18", 0, 0.123, 0, V8DOMConfiguration::ConstantTypeDouble},
- {"CONST_VALUE_19", 0, 4e9, 0, V8DOMConfiguration::ConstantTypeDouble},
- {"CONST_VALUE_20", 0, 3.4e5, 0, V8DOMConfiguration::ConstantTypeDouble},
- {"CONST_VALUE_21", 0, -1.3, 0, V8DOMConfiguration::ConstantTypeDouble},
- {"CONST_VALUE_22", 0, -4e-9, 0, V8DOMConfiguration::ConstantTypeDouble},
- {"CONST_VALUE_23", 0, .123, 0, V8DOMConfiguration::ConstantTypeDouble},
- {"CONST_VALUE_24", 0, 5E+4, 0, V8DOMConfiguration::ConstantTypeDouble},
- {"CONST_VALUE_25", 0, 1, 0, V8DOMConfiguration::ConstantTypeFloat},
- {"CONST_JAVASCRIPT", 1, 0, 0, V8DOMConfiguration::ConstantTypeShort},
+ {"CONST_VALUE_0", 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_1", 1, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_2", 2, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_4", 4, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_8", 8, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_9", -1, 0, V8DOMConfiguration::ConstantTypeShort},
+ {"CONST_VALUE_11", 0xffffffff, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_12", 0x01, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_13", 0X20, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_14", 0x1abc, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_15", 010, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_16", -010, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_16", -0x1A, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_17", -0X1a, 0, V8DOMConfiguration::ConstantTypeUnsignedShort},
+ {"CONST_VALUE_18", 0, 0.123, V8DOMConfiguration::ConstantTypeDouble},
+ {"CONST_VALUE_19", 0, 4e9, V8DOMConfiguration::ConstantTypeDouble},
+ {"CONST_VALUE_20", 0, 3.4e5, V8DOMConfiguration::ConstantTypeDouble},
+ {"CONST_VALUE_21", 0, -1.3, V8DOMConfiguration::ConstantTypeDouble},
+ {"CONST_VALUE_22", 0, -4e-9, V8DOMConfiguration::ConstantTypeDouble},
+ {"CONST_VALUE_23", 0, .123, V8DOMConfiguration::ConstantTypeDouble},
+ {"CONST_VALUE_24", 0, 5E+4, V8DOMConfiguration::ConstantTypeDouble},
+ {"CONST_VALUE_25", 0, 1, V8DOMConfiguration::ConstantTypeFloat},
+ {"CONST_JAVASCRIPT", 1, 0, V8DOMConfiguration::ConstantTypeShort},
};
V8DOMConfiguration::installConstants(isolate, functionTemplate, prototypeTemplate, V8TestObjectConstants, WTF_ARRAY_LENGTH(V8TestObjectConstants));
if (RuntimeEnabledFeatures::featureNameEnabled()) {
- static const V8DOMConfiguration::ConstantConfiguration constantConfiguration = {"FEATURE_ENABLED_CONST", 1, 0, 0, V8DOMConfiguration::ConstantTypeShort};
+ static const V8DOMConfiguration::ConstantConfiguration constantConfiguration = {"FEATURE_ENABLED_CONST", 1, 0, V8DOMConfiguration::ConstantTypeShort};
V8DOMConfiguration::installConstant(isolate, functionTemplate, prototypeTemplate, constantConfiguration);
}
V8DOMConfiguration::installConstantWithGetter(isolate, functionTemplate, prototypeTemplate, "DEPRECATED_CONSTANT", TestObjectV8Internal::DEPRECATED_CONSTANTConstantGetterCallback);
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface2.cpp ('k') | Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698