Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1315643002: Merge 200961 "Set ArrayBufferContents size to 0 on allocation fa..." (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
Reviewers:
tkent, haraken, binji
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, tkent
Visibility:
Public.

Description

Merge 200961 "Set ArrayBufferContents size to 0 on allocation fa..." > Set ArrayBufferContents size to 0 on allocation failure > > Also, add a RELEASE_ASSERT when creating an ArrayBuffer from an > ArrayBufferContents that the backing store is non-NULL. > > BUG=522128 > > Review URL: https://codereview.chromium.org/1302193002 TBR=binji@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/wtf/ArrayBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/ArrayBufferContents.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
binji
5 years, 4 months ago (2015-08-24 17:24:10 UTC) #1
binji
+tkent, haraken
5 years, 4 months ago (2015-08-24 18:37:00 UTC) #2
binji
Committed patchset #1 (id:1) manually as r201070.
5 years, 4 months ago (2015-08-24 19:39:26 UTC) #5
tkent
lgtm
5 years, 4 months ago (2015-08-24 23:00:57 UTC) #7
haraken
5 years, 4 months ago (2015-08-24 23:17:30 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698