Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1302193002: Set ArrayBufferContents size to 0 on allocation failure (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set ArrayBufferContents size to 0 on allocation failure Also, add a RELEASE_ASSERT when creating an ArrayBuffer from an ArrayBufferContents that the backing store is non-NULL. BUG=522128 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/wtf/ArrayBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/ArrayBufferContents.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
adamk
I'm not a wtf owner, so I won't be able to help much, but it ...
5 years, 4 months ago (2015-08-20 23:15:12 UTC) #2
binji
On 2015/08/20 at 23:15:12, adamk wrote: > I'm not a wtf owner, so I won't ...
5 years, 4 months ago (2015-08-20 23:17:10 UTC) #3
binji
+jchaffraix for OWNERS
5 years, 4 months ago (2015-08-20 23:24:55 UTC) #6
adamk
+ a few more wtf OWNERs just in case
5 years, 4 months ago (2015-08-20 23:36:24 UTC) #8
tkent
lgtm
5 years, 4 months ago (2015-08-21 00:05:20 UTC) #9
haraken
LGTM
5 years, 4 months ago (2015-08-21 00:09:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302193002/1
5 years, 4 months ago (2015-08-21 01:34:02 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 04:40:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200961

Powered by Google App Engine
This is Rietveld 408576698