Source/web/WebRange.cpp - Issue 1315543002: Introduce createRange(const EphemeralRange&)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRange.cpp

Issue 1315543002: Introduce createRange(const EphemeralRange&) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebRange.cpp

diff --git a/Source/web/WebRange.cpp b/Source/web/WebRange.cpp

index 1846be3ebd39ba3a2cbf8d278c6933176edb4cbd..0c22c42c6525c841b62e1b99873c880e2ba516c2 100644

--- a/Source/web/WebRange.cpp

+++ b/Source/web/WebRange.cpp

@@ -83,7 +83,7 @@ WebRange WebRange::fromDocumentRange(WebLocalFrame* frame, int start, int length

const EphemeralRange range = PlainTextRange(start, start + length).createRange(*scope);

if (range.isNull())

tkent 2015/08/24 09:38:06 We can remove these two lines.

yosin_UTC9 2015/08/24 13:19:22 Done

return WebRange();

- return Range::create(range.document(), range.startPosition(), range.endPosition());

+ return createRange(range);

}

WebRange::WebRange(const PassRefPtrWillBeRawPtr<Range>& range)