Source/core/testing/Internals.cpp - Issue 1315543002: Introduce createRange(const EphemeralRange&)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/Internals.cpp

Issue 1315543002: Introduce createRange(const EphemeralRange&) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/testing/Internals.cpp

diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp

index 263ba12f6687ca66842b49d3a1f48af99598472b..dafa378036dbffafa9a7e3f543321e7c1c636ff2 100644

--- a/Source/core/testing/Internals.cpp

+++ b/Source/core/testing/Internals.cpp

@@ -1029,7 +1029,7 @@ PassRefPtrWillBeRawPtr<Range> Internals::rangeFromLocationAndLength(Element* sco

const EphemeralRange range = PlainTextRange(rangeLocation, rangeLocation + rangeLength).createRange(*scope);

if (range.isNull())

tkent 2015/08/24 09:38:05 We can remove these two lines.

yosin_UTC9 2015/08/24 13:19:22 Done

return nullptr;

- return Range::create(range.document(), range.startPosition(), range.endPosition());

+ return createRange(range);

}

unsigned Internals::locationFromRange(Element* scope, const Range* range)