Introduce createRange(const EphemeralRange&)

Introduce createRange(const EphemeralRange&)

This patch introduces |createRange(const EphemeralRange&)| to replace
|Range::create()| with |EphemeralRange| patterns for simplify source code.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201062

[yosin_UTC9, 2015-08-24 09:12:48]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2015-08-24 09:13:14]

PTAL

[tkent, 2015-08-24 09:36:33]

lgtm

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/Ephemer...
File Source/core/editing/EphemeralRange.h (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/Ephemer...
Source/core/editing/EphemeralRange.h:90: CORE_EXPORT
PassRefPtrWillBeRawPtr<Range> createRange(const EphemeralRange&);
Need a comment that this function can return null PassRefPtr / nullptr.

[tkent, 2015-08-24 09:38:06]

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/InputMe...
File Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/InputMe...
Source/core/editing/InputMethodController.cpp:358: if (range.isNull())
We can remove these two lines.

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisibleSelection.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisibleSelection.cpp:246: if (range.isNull())
We can remove these two lines.

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/spellch...
File Source/core/editing/spellcheck/TextCheckingHelper.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/spellch...
Source/core/editing/spellcheck/TextCheckingHelper.cpp:169: if (range.isNull())
We can remove these two lines.

https://codereview.chromium.org/1315543002/diff/1/Source/core/testing/Interna...
File Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/testing/Interna...
Source/core/testing/Internals.cpp:1030: if (range.isNull())
We can remove these two lines.

https://codereview.chromium.org/1315543002/diff/1/Source/web/WebRange.cpp
File Source/web/WebRange.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/web/WebRange.cpp#new...
Source/web/WebRange.cpp:84: if (range.isNull())
We can remove these two lines.

[yosin_UTC9, 2015-08-24 13:19:22]

Thanks!

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/Ephemer...
File Source/core/editing/EphemeralRange.h (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/Ephemer...
Source/core/editing/EphemeralRange.h:90: CORE_EXPORT
PassRefPtrWillBeRawPtr<Range> createRange(const EphemeralRange&);
On 2015/08/24 at 09:36:33, tkent wrote:
> Need a comment that this function can return null PassRefPtr / nullptr.
Done.

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/InputMe...
File Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/InputMe...
Source/core/editing/InputMethodController.cpp:358: if (range.isNull())
On 2015/08/24 at 09:38:05, tkent wrote:
> We can remove these two lines.

Done.

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisibleSelection.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisibleSelection.cpp:246: if (range.isNull())
On 2015/08/24 at 09:38:05, tkent wrote:
> We can remove these two lines.

Done

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/spellch...
File Source/core/editing/spellcheck/TextCheckingHelper.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/editing/spellch...
Source/core/editing/spellcheck/TextCheckingHelper.cpp:169: if (range.isNull())
On 2015/08/24 at 09:38:05, tkent wrote:
> We can remove these two lines.
Done.

https://codereview.chromium.org/1315543002/diff/1/Source/core/testing/Interna...
File Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/core/testing/Interna...
Source/core/testing/Internals.cpp:1030: if (range.isNull())
On 2015/08/24 at 09:38:05, tkent wrote:
> We can remove these two lines.

Done

https://codereview.chromium.org/1315543002/diff/1/Source/web/WebRange.cpp
File Source/web/WebRange.cpp (right):

https://codereview.chromium.org/1315543002/diff/1/Source/web/WebRange.cpp#new...
Source/web/WebRange.cpp:84: if (range.isNull())
On 2015/08/24 at 09:38:06, tkent wrote:
> We can remove these two lines.

Done

[yosin_UTC9, 2015-08-24 13:19:29]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-24 13:19:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1315543002/#ps20001
(title: "2015-08-24T22:18:16")

[commit-bot: I haz the power, 2015-08-24 13:19:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315543002/20001

[commit-bot: I haz the power, 2015-08-24 15:13:29]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201062