Source/core/editing/spellcheck/TextCheckingHelper.cpp - Issue 1315543002: Introduce createRange(const EphemeralRange&)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/spellcheck/TextCheckingHelper.cpp

Issue 1315543002: Introduce createRange(const EphemeralRange&) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-24T22:18:16 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/spellcheck/TextCheckingHelper.cpp

diff --git a/Source/core/editing/spellcheck/TextCheckingHelper.cpp b/Source/core/editing/spellcheck/TextCheckingHelper.cpp

index 9abac4c443ccfb672f7aa115bb0c092cefbb4163..8640c0578f3044c81763e9c058e4a1d39313ff48 100644

--- a/Source/core/editing/spellcheck/TextCheckingHelper.cpp

+++ b/Source/core/editing/spellcheck/TextCheckingHelper.cpp

@@ -165,10 +165,7 @@ PassRefPtrWillBeRawPtr<Range> TextCheckingParagraph::paragraphRange() const

PassRefPtrWillBeRawPtr<Range> TextCheckingParagraph::subrange(int characterOffset, int characterCount) const

{

ASSERT(m_checkingRange);

- EphemeralRange range = calculateCharacterSubrange(EphemeralRange(paragraphRange().get()), characterOffset, characterCount);

- if (range.isNull())

- return nullptr;

- return Range::create(range.document(), range.startPosition(), range.endPosition());

+ return createRange(calculateCharacterSubrange(EphemeralRange(paragraphRange().get()), characterOffset, characterCount));

}

int TextCheckingParagraph::offsetTo(const Position& position, ExceptionState& exceptionState) const

« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »