Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: Source/core/editing/VisibleSelection.h

Issue 1315513005: Get rid of unused member function toNormalizedRange() from FrameSelection and VisibleSelection class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-26T11:07:51 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.h ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisibleSelection.h
diff --git a/Source/core/editing/VisibleSelection.h b/Source/core/editing/VisibleSelection.h
index ef29a637343b7302b955784c1fdda97508d7c868..4e8599042dbc4cfed319d5a369ea0e2b7d1bb522 100644
--- a/Source/core/editing/VisibleSelection.h
+++ b/Source/core/editing/VisibleSelection.h
@@ -155,11 +155,10 @@ public:
bool intersectsNode(Node*) const;
- // FIXME: Most callers probably don't want these functions, but
- // are using them for historical reasons. toNormalizedRange and
- // toNormalizedEphemeralRange contracts the range around text, and
- // moves the caret upstream before returning the range/positions.
- PassRefPtrWillBeRawPtr<Range> toNormalizedRange() const;
+ // TODO(yosin) Most callers probably don't want these functions, but
+ // are using them for historical reasons. |toNormalizedEphemeralRange()|
+ // contracts the range around text, and moves the caret most backward
+ // visually equivalent position before returning the range/positions.
EphemeralRange toNormalizedEphemeralRange() const;
static EphemeralRange normalizeRange(const EphemeralRange&);
static EphemeralRangeInComposedTree normalizeRange(const EphemeralRangeInComposedTree&);
« no previous file with comments | « Source/core/editing/FrameSelection.h ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698