Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1315503005: link test to bug (Closed)

Created:
5 years, 3 months ago by caryclark
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

link test to bug crbug.com/526025 includes a minimized SVG test case. Translating that test case into native code (fuzzTNG) did not reproduce the bug. That test case should have not been included with skia issue 1323813003, and is deleted here. Running the minimal test case in a modified version of chrome isolated the bug. The modified version generated the test fuzz763_3 with the edit #define DEBUGGING_PATHOPS_FROM_HOST 1 in src/pathops/SkPathopsOp.cpp line 188. Rename fuzz763_3 to issue_526025 to associate the test with the bug. Note that the bug contains the body of the CL in comment $5. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/580c40ae71a4914a9f4fa247accf86810e3463db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M tests/PathOpsBuilderTest.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315503005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315503005/1
5 years, 3 months ago (2015-09-01 12:06:20 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-01 12:06:21 UTC) #3
caryclark
Is this what you had in mind with your feedback in https://codereview.chromium.org/1323813003 ?
5 years, 3 months ago (2015-09-01 12:07:59 UTC) #4
reed1
lgtm
5 years, 3 months ago (2015-09-01 13:20:53 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 13:22:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/580c40ae71a4914a9f4fa247accf86810e3463db

Powered by Google App Engine
This is Rietveld 408576698