Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1323813003: remove duplicate linked list adjustment (Closed)

Created:
5 years, 3 months ago by caryclark
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove duplicate linked list adjustment The list of intersection points on a curve segment may have entries that can be safely removed when nearby points have nearly the same t value and point value. When a path includes very large curves as well as small ones, as is the case with this fuzzer, additional points may lie between the similar points that do not meet the nearby criteria. After merging the nearby point with its doppelganger, SkOpSegment::moveNearby() unnecessarily set the doppelganger's next pointer to the one following the nearby point. While this usually has no effect, since the merge already updated the linked list, the explicit call removes the additional outlier points from the segment. TBR=reed@google.com BUG=526025 Committed: https://skia.googlesource.com/skia/+/ae576b733dc427761bd254dcce5ae5a1c5d552df

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M src/pathops/SkOpSegment.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 chunk +23 lines, -0 lines 1 comment Download
M tests/PathOpsOpTest.cpp View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323813003/1
5 years, 3 months ago (2015-08-31 16:41:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ae576b733dc427761bd254dcce5ae5a1c5d552df
5 years, 3 months ago (2015-08-31 16:46:23 UTC) #3
reed1
https://codereview.chromium.org/1323813003/diff/1/tests/PathOpsBuilderTest.cpp File tests/PathOpsBuilderTest.cpp (right): https://codereview.chromium.org/1323813003/diff/1/tests/PathOpsBuilderTest.cpp#newcode276 tests/PathOpsBuilderTest.cpp:276: DEF_TEST(fuzzTNG, reporter) { can we tie this test to ...
5 years, 3 months ago (2015-08-31 21:11:01 UTC) #4
caryclark
5 years, 3 months ago (2015-09-01 11:33:01 UTC) #5
Message was sent while issue was closed.
On 2015/08/31 21:11:01, reed1 wrote:
> https://codereview.chromium.org/1323813003/diff/1/tests/PathOpsBuilderTest.cpp
> File tests/PathOpsBuilderTest.cpp (right):
> 
>
https://codereview.chromium.org/1323813003/diff/1/tests/PathOpsBuilderTest.cp...
> tests/PathOpsBuilderTest.cpp:276: DEF_TEST(fuzzTNG, reporter) {
> can we tie this test to a bug or even CL? Your description in the CL was very
> detalied. Perhaps some of that should be referenced from here, to
justify/motive
> this test.

I'll create a separate CL to address this.

Powered by Google App Engine
This is Rietveld 408576698