Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1315443012: Revert of Pre-cache downloads directory path in PathUtils. (patchset #1 id:1 of https://codereview.… (Closed)

Created:
5 years, 3 months ago by mimee
Modified:
5 years, 3 months ago
Reviewers:
Peter Wen, Yaron, yfriedman
CC:
chromium-reviews, acleung1
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Revert of Pre-cache downloads directory path in PathUtils. (patchset #1 id:1 of https://codereview.chromium.org/1281273003/ ) Reason for revert: Revert because it breaks new beta. See https://code.google.com/p/chromium/issues/detail?id=528377 Original issue's description: > Pre-cache downloads directory path in PathUtils. > > When Chrome tabs are swiped away and user starts Chrome again, > their default downloads directory is requested. This causes a > StrictMode policy violation since it results in a ~60ms disk > read. Thus by adding this call to the initial AsyncTask we > save that time when the directory is requested by native. > > This must only be called in the browser process as the sandbox > processes do not need to make the call nor can they make the > call(results in NPE). > > BUG=508615 > > Committed: https://crrev.com/4a7568dffab924d3710a68949dca0717bdad3352 > Cr-Commit-Position: refs/heads/master@{#342672} TBR=yfriedman@google.com,wnwen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508615 TBR=acleung@chromium.org Review URL: https://codereview.chromium.org/1328043002 Cr-Commit-Position: refs/heads/master@{#347518}

Patch Set 1 #

Patch Set 2 : Added the commit SHA from which it is cherry-picked. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M base/android/java/src/org/chromium/base/PathUtils.java View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Yaron
lgtm
5 years, 3 months ago (2015-09-08 18:00:38 UTC) #2
Peter Wen
lgtm
5 years, 3 months ago (2015-09-08 18:02:14 UTC) #3
Peter Wen
5 years, 3 months ago (2015-09-10 21:54:46 UTC) #4
On 2015/09/08 18:02:14, Peter Wen wrote:
> lgtm

Closing this issue as http://crrev.com/1328043002 landed.

Powered by Google App Engine
This is Rietveld 408576698