Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1328043002: Revert of Pre-cache downloads directory path in PathUtils. (Closed)

Created:
5 years, 3 months ago by mimee1
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pre-cache downloads directory path in PathUtils. (patchset #1 id:1 of https://codereview.chromium.org/1281273003/ ) Reason for revert: Revert because it breaks new beta. See https://code.google.com/p/chromium/issues/detail?id=528377 Original issue's description: > Pre-cache downloads directory path in PathUtils. > > When Chrome tabs are swiped away and user starts Chrome again, > their default downloads directory is requested. This causes a > StrictMode policy violation since it results in a ~60ms disk > read. Thus by adding this call to the initial AsyncTask we > save that time when the directory is requested by native. > > This must only be called in the browser process as the sandbox > processes do not need to make the call nor can they make the > call(results in NPE). > > BUG=508615 > > Committed: https://crrev.com/4a7568dffab924d3710a68949dca0717bdad3352 > Cr-Commit-Position: refs/heads/master@{#342672} TBR=yfriedman@google.com,wnwen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528377 Committed: https://crrev.com/76a40f98082e9cc63416bf1722eb2dabc65880f5 Cr-Commit-Position: refs/heads/master@{#347518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M base/android/java/src/org/chromium/base/PathUtils.java View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mimee1
Created Revert of Pre-cache downloads directory path in PathUtils.
5 years, 3 months ago (2015-09-04 22:29:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328043002/1
5 years, 3 months ago (2015-09-04 22:30:09 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-04 22:30:10 UTC) #4
acleung1
lgtm
5 years, 3 months ago (2015-09-04 22:53:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328043002/1
5 years, 3 months ago (2015-09-04 22:53:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 22:54:21 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 22:55:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76a40f98082e9cc63416bf1722eb2dabc65880f5
Cr-Commit-Position: refs/heads/master@{#347518}

Powered by Google App Engine
This is Rietveld 408576698