Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 131543014: cc: Use std::map instead of hash_map for TaskGraphRunner namespaces. (Closed)

Created:
5 years, 7 months ago by reveman
Modified:
5 years, 7 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Use std::map instead of hash_map for TaskGraphRunner namespaces. This avoids some heap allocations and provides more than good enough namespace lookup performance for the number of namespaces used in practice. Also provides a ~300% performance improvement in cases where the task graph only contains a single task. BUG=246546 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -34 lines) Patch
M cc/resources/task_graph_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/task_graph_runner.cc View 7 chunks +25 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reveman
5 years, 7 months ago (2014-02-10 16:34:17 UTC) #1
vmpstr
lgtm. What do you mean 300% improvement with a single task? Do you mean a ...
5 years, 7 months ago (2014-02-10 16:52:51 UTC) #2
reveman
On 2014/02/10 16:52:51, vmpstr wrote: > lgtm. What do you mean 300% improvement with a ...
5 years, 7 months ago (2014-02-10 17:26:40 UTC) #3
reveman
The CQ bit was checked by reveman@chromium.org
5 years, 7 months ago (2014-02-10 17:26:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/131543014/1
5 years, 7 months ago (2014-02-10 17:26:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 7 months ago (2014-02-10 18:23:18 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=260804
5 years, 7 months ago (2014-02-10 18:23:20 UTC) #7
reveman
The CQ bit was checked by reveman@chromium.org
5 years, 7 months ago (2014-02-10 18:44:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/131543014/1
5 years, 7 months ago (2014-02-10 18:44:42 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2014-02-10 22:29:58 UTC) #10
Message was sent while issue was closed.
Change committed as 250222

Powered by Google App Engine
This is Rietveld 408576698