Issue 131543006: Revert 243986 "Fix AdjustBoundsToEnsureWindowVisibility to work ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131543006: Revert 243986 "Fix AdjustBoundsToEnsureWindowVisibility to work ..." (Closed)

Created:
6 years, 11 months ago by oshima

Modified:
6 years, 11 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 243986 "Fix AdjustBoundsToEnsureWindowVisibility to work ..." > Fix AdjustBoundsToEnsureWindowVisibility to work with non primary display bounds > This was asssuming that the visibile area has 0,0 origin. > > Move the code to ensure minimum visibility when added, from > WorkspaceLayoutManager to DragWindowResizer. > > BUG=none > TEST=WindowUtilTest.AdjustBoundsToEnsureWindowVisibility. > This also fixes the test that was failing. > TBR=oshima@chromium.org > > Review URL: https://codereview.chromium.org/106303005 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244021

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -105 lines)			Patch
M	trunk/src/ash/display/screen_position_controller.cc	View	3 chunks	+1 line, -17 lines	0 comments	Download
M	trunk/src/ash/wm/dock/docked_window_layout_manager.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/ash/wm/drag_window_resizer.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/ash/wm/drag_window_resizer_unittest.cc	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	trunk/src/ash/wm/system_gesture_event_filter_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/wm/window_util.cc	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	trunk/src/ash/wm/window_util_unittest.cc	View	2 chunks	+0 lines, -60 lines	0 comments	Download
M	trunk/src/ash/wm/workspace/workspace_layout_manager.cc	View	2 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r244021.

Expand Messages | Collapse Messages