Add chrome.virtualKeyboardPrivate.setHotrodKeyboard api

Add chrome.virtualKeyboardPrivate.setHotrodKeyboard api

BUG=524291
Committed: https://crrev.com/582fd8ffce3ba6df325dffc0fe80066855991074
Cr-Commit-Position: refs/heads/master@{#347873}

[bshe, 2015-09-08 21:38:57]

bshe@chromium.org changed reviewers:
+ rsadam@chromium.org

[bshe, 2015-09-08 21:38:57]

Hey Raheem.

Do you mind to take a look at this CL? I decide to just make the
setHotrodKeyboard api instead of letting user set the keyset name. It is easier
to do so and if in the future we do need a second keyset. We will then discuss
the design.

Thanks

[rsadam, 2015-09-08 21:48:22]

https://codereview.chromium.org/1315233006/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
(right):

https://codereview.chromium.org/1315233006/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc:129:
if (enable && keyboard::IsKeyboardEnabled())
Does this actually reload the keyboard? Looking through RWC it's not obvious to
me. My concern is there might be a memory leak if the keyboard already exists.

[rsadam, 2015-09-08 21:53:48]

On 2015/09/08 21:48:22, rsadam wrote:
>
https://codereview.chromium.org/1315233006/diff/1/chrome/browser/extensions/a...
> File
>
chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
> (right):
> 
>
https://codereview.chromium.org/1315233006/diff/1/chrome/browser/extensions/a...
>
chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc:129:
> if (enable && keyboard::IsKeyboardEnabled())
> Does this actually reload the keyboard? Looking through RWC it's not obvious
to
> me. My concern is there might be a memory leak if the keyboard already exists.

Issue addressed offline. InitKeyboard in Shell.cc does the cleanup.

LGTM

[bshe, 2015-09-08 21:59:57]

bshe@chromium.org changed reviewers:
+ isherman@chromium.org, rockot@chromium.org

[bshe, 2015-09-08 21:59:58]

Thanks Raheem!

+owners:
rockot@ for extensions/common/api/virtual_keyboard_private.json
isherman@ for
extensions/browser/extension_function_histogram_value.h
tools/metrics/histograms/histograms.xml

[Ilya Sherman, 2015-09-08 22:00:31]

histograms.xml lgtm

[Ken Rockot(use gerrit already), 2015-09-08 22:02:41]

json lgtm

[bshe, 2015-09-08 22:18:52]

The CQ bit was checked by bshe@chromium.org

[bshe, 2015-09-08 22:18:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
rsadam@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1315233006/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-09-08 22:19:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315233006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315233006/40001

[commit-bot: I haz the power, 2015-09-08 23:27:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 23:27:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bshe, 2015-09-09 01:41:17]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2015-09-09 01:41:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315233006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315233006/40001

[commit-bot: I haz the power, 2015-09-09 09:08:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-09 09:09:33]

Patchset 3 (id:??) landed as
https://crrev.com/582fd8ffce3ba6df325dffc0fe80066855991074
Cr-Commit-Position: refs/heads/master@{#347873}