Fix warnings produced by g++ on Windows.

Fix warnings produced by g++ on Windows.

Scraped non-pragma related warnings from a recent trybot run:

wget -O - 'http://build.chromium.org/p/tryserver.nacl/builders/nacl-toolchain-win7-pnacl-x86_64/builds/3221/steps/llvm_i686_w64_mingw32%20%28build%29/logs/stdio' | grep subzero | grep warning | grep -v pragma

BUG= none
R=ascull@google.com, jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a8d4713798086ceffeb406392ddaad2faaf2aca5

[Jim Stichnoth, 2015-09-08 20:53:05]

stichnot@chromium.org changed reviewers:
+ ascull@google.com, jpp@chromium.org

[ascull, 2015-09-08 21:16:47]

https://codereview.chromium.org/1315193020/diff/1/src/IceCfgNode.cpp
File src/IceCfgNode.cpp (right):

https://codereview.chromium.org/1315193020/diff/1/src/IceCfgNode.cpp#newcode243
src/IceCfgNode.cpp:243: assert(Found);
Does this need a `(void)Found` too? Seems to be the same pattern.

[Jim Stichnoth, 2015-09-08 21:28:11]

https://codereview.chromium.org/1315193020/diff/1/src/IceCfgNode.cpp
File src/IceCfgNode.cpp (right):

https://codereview.chromium.org/1315193020/diff/1/src/IceCfgNode.cpp#newcode243
src/IceCfgNode.cpp:243: assert(Found);
On 2015/09/08 21:16:47, ascull wrote:
> Does this need a `(void)Found` too? Seems to be the same pattern.

Oops, done.

I opted to repeat the void-cast at each assert, instead of doing it just once,
lest a clever optimizer complain that dominated assignments are useless.

[ascull, 2015-09-08 21:29:41]

lgtm

[ascull, 2015-09-08 21:29:42]

lgtm

[John, 2015-09-08 21:42:51]

lgtm

[Jim Stichnoth, 2015-09-08 21:43:51]

Committed patchset #2 (id:20001) manually as
a8d4713798086ceffeb406392ddaad2faaf2aca5 (presubmit successful).