Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: chrome/installer/mac/sign_versioned_dir.sh.in

Issue 1315163004: Remove the unused helper apps on OS X. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restore comment per review. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/sign_versioned_dir.sh.in
diff --git a/chrome/installer/mac/sign_versioned_dir.sh.in b/chrome/installer/mac/sign_versioned_dir.sh.in
index 2a09ac6bf704cd4a6914d091f93a198ed8b25e78..e13474292ea76e1b3ad0ce97c9a0a5c659f58e82 100644
--- a/chrome/installer/mac/sign_versioned_dir.sh.in
+++ b/chrome/installer/mac/sign_versioned_dir.sh.in
@@ -43,8 +43,6 @@ versioned_dir="${app_path}/Contents/Versions/@VERSION@"
framework="${versioned_dir}/@MAC_PRODUCT_NAME@ Framework.framework"
crashpad_handler="${framework}/Helpers/crashpad_handler"
helper_app="${versioned_dir}/@MAC_PRODUCT_NAME@ Helper.app"
-helper_eh_app="${versioned_dir}/@MAC_PRODUCT_NAME@ Helper EH.app"
-helper_np_app="${versioned_dir}/@MAC_PRODUCT_NAME@ Helper NP.app"
requirement_suffix="\
and certificate leaf = H\"85cee8254216185620ddc8851c7a9fc4dfe120ef\"\
@@ -62,19 +60,9 @@ codesign --sign "${codesign_id}" --keychain "${codesign_keychain}" \
"${helper_app}" \
-r="designated => identifier \"com.google.Chrome.helper\" \
${requirement_suffix}"
-codesign --sign "${codesign_id}" --keychain "${codesign_keychain}" \
- "${helper_eh_app}" \
- -r="designated => identifier \"com.google.Chrome.helper.EH\" \
-${requirement_suffix}"
-codesign --sign "${codesign_id}" --keychain "${codesign_keychain}" \
- "${helper_np_app}" \
- -r="designated => identifier \"com.google.Chrome.helper.NP\" \
-${requirement_suffix}"
# Verify everything. Don't use --deep on the framework because Keystone's
# signature is in a transitional state (radar 18474911).
codesign --verify --deep "${crashpad_handler}"
codesign --verify "${framework}"
codesign --verify --deep "${helper_app}"
-codesign --verify --deep "${helper_eh_app}"
-codesign --verify --deep "${helper_np_app}"

Powered by Google App Engine
This is Rietveld 408576698