chrome/common/chrome_constants.cc - Issue 1315163004: Remove the unused helper apps on OS X.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_constants.cc

Issue 1315163004: Remove the unused helper apps on OS X. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restore comment per review. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/chrome_constants.cc

diff --git a/chrome/common/chrome_constants.cc b/chrome/common/chrome_constants.cc

index e41e836ec4e26efc1970c07095d23981dd3cd46f..bac0a5a6df663fb9364114d3181439bc0a0b3ce2 100644

--- a/chrome/common/chrome_constants.cc

+++ b/chrome/common/chrome_constants.cc

@@ -119,8 +119,6 @@ const base::FilePath::CharType kFrameworkName[] =

FPL(PRODUCT_STRING " Framework.framework");

const char* const kHelperFlavorSuffixes[] = {

Nico 2015/09/01 23:27:16 Can this be removed altogether? Or will this grow

Greg K 2015/09/01 23:50:15 Yes, soon NLV suffix will be added and I would pre

Nico 2015/09/01 23:52:55 Makes sense.

- FPL("EH"), // Executable heap

- FPL("NP"), // No PIE

NULL

};

#endif // OS_MACOSX

« no previous file with comments | « chrome/chrome_exe.gypi ('k') | chrome/installer/mac/sign_app.sh.in » ('j') | no next file with comments »