Remove the unused helper apps on OS X.

Remove the unused helper apps on OS X.

On OS X, there are currently Google Chrome Helper EH.app and
Google Chrome Helper NP.app, which are no longer used with the deprecation
of NPAPI. This changes removes the helpers, both from the build process,
and any code referring to them.

The make_more_helpers.sh is now a no-op, but is left in because it will
soon be needed for the Library Validation feature (to generate
Google Chrome Helper NLV.app).

BUG=520680
Committed: https://crrev.com/f5ed554ef814418d64510aa18b43b69315e40814
Cr-Commit-Position: refs/heads/master@{#347235}

[Greg K, 2015-08-27 22:50:26]

kerrnel@chromium.org changed reviewers:
+ jochen@chromium.org

[Greg K, 2015-08-27 22:54:23]

kerrnel@chromium.org changed reviewers:
+ mark@chromium.org

[Greg K, 2015-08-27 22:55:10]

kerrnel@chromium.org changed reviewers:
- jochen@chromium.org

[Mark Mentovai, 2015-08-31 17:47:42]

LGTM otherwise

https://codereview.chromium.org/1315163004/diff/20001/build/mac/make_more_hel...
File build/mac/make_more_helpers.sh (left):

https://codereview.chromium.org/1315163004/diff/20001/build/mac/make_more_hel...
build/mac/make_more_helpers.sh:90: make_helper "${CONTAINING_DIR}" "${APP_NAME}"
"EH" "--executable-heap"
This whole script is a no-op now. Are you still keeping this script because you
want to reuse it soon? If so, put a comment about that in the change
description. Otherwise, remove the postbuild step that runs it and delete it,
and if we need it again in the future, we can resurrect it from version history.

https://codereview.chromium.org/1315163004/diff/20001/content/public/common/c...
File content/public/common/child_process_host.h (left):

https://codereview.chromium.org/1315163004/diff/20001/content/public/common/c...
content/public/common/child_process_host.h:85: // The |flags| argument accepts
one or more flags such as CHILD_ALLOW_SELF
Don’t get rid of this entire comment, since CHILD_ALLOW_SELF (Linux) is sticking
around.

[Greg K, 2015-09-01 23:18:05]

kerrnel@chromium.org changed reviewers:
+ mseaborn@chromium.org, nasko@chromium.org, thakis@chromium.org

[Greg K, 2015-09-01 23:18:06]

mseaborn@chromium.org: Please review changes in 
components/nacl/browser/nacl_process_host.cc

thakis@chromium.org: Please review changes in 
chrome/app/chrome_main_delegate.cc
chrome/common/chrome_constants.cc

nasko@chromium.org: Please review changes in 
components/nacl/browser/nacl_process_host.cc
content/browser/plugin_loader_posix.cc
content/browser/plugin_process_host.cc
content/common/child_process_host_impl.cc
content/public/common/child_process_host.h

https://codereview.chromium.org/1315163004/diff/20001/build/mac/make_more_hel...
File build/mac/make_more_helpers.sh (left):

https://codereview.chromium.org/1315163004/diff/20001/build/mac/make_more_hel...
build/mac/make_more_helpers.sh:90: make_helper "${CONTAINING_DIR}" "${APP_NAME}"
"EH" "--executable-heap"
On 2015/08/31 17:47:42, Mark Mentovai - August is over wrote:
> This whole script is a no-op now. Are you still keeping this script because
you
> want to reuse it soon? If so, put a comment about that in the change
> description. Otherwise, remove the postbuild step that runs it and delete it,
> and if we need it again in the future, we can resurrect it from version
history.

We'll need this again for the Google Chrome Helper NLV.app, so I want to leave
this in as a no-op.

https://codereview.chromium.org/1315163004/diff/20001/content/public/common/c...
File content/public/common/child_process_host.h (left):

https://codereview.chromium.org/1315163004/diff/20001/content/public/common/c...
content/public/common/child_process_host.h:85: // The |flags| argument accepts
one or more flags such as CHILD_ALLOW_SELF
On 2015/08/31 17:47:42, Mark Mentovai - August is over wrote:
> Don’t get rid of this entire comment, since CHILD_ALLOW_SELF (Linux) is
sticking
> around.

Done.

[Nico, 2015-09-01 23:27:16]

cool! chrome/ lgtm

https://codereview.chromium.org/1315163004/diff/40001/chrome/common/chrome_co...
File chrome/common/chrome_constants.cc (right):

https://codereview.chromium.org/1315163004/diff/40001/chrome/common/chrome_co...
chrome/common/chrome_constants.cc:121: const char* const kHelperFlavorSuffixes[]
= {
Can this be removed altogether? Or will this grow an NVL suffix soon?

[Greg K, 2015-09-01 23:50:16]

https://codereview.chromium.org/1315163004/diff/40001/chrome/common/chrome_co...
File chrome/common/chrome_constants.cc (right):

https://codereview.chromium.org/1315163004/diff/40001/chrome/common/chrome_co...
chrome/common/chrome_constants.cc:121: const char* const kHelperFlavorSuffixes[]
= {
On 2015/09/01 23:27:16, Nico wrote:
> Can this be removed altogether? Or will this grow an NVL suffix soon?

Yes, soon NLV suffix will be added and I would prefer to limit the amount of
code that I'll have to delete and re-add.

[Nico, 2015-09-01 23:52:55]

https://codereview.chromium.org/1315163004/diff/40001/chrome/common/chrome_co...
File chrome/common/chrome_constants.cc (right):

https://codereview.chromium.org/1315163004/diff/40001/chrome/common/chrome_co...
chrome/common/chrome_constants.cc:121: const char* const kHelperFlavorSuffixes[]
= {
On 2015/09/01 23:50:15, Greg Kerr wrote:
> On 2015/09/01 23:27:16, Nico wrote:
> > Can this be removed altogether? Or will this grow an NVL suffix soon?
> 
> Yes, soon NLV suffix will be added and I would prefer to limit the amount of
> code that I'll have to delete and re-add.

Makes sense.

[nasko, 2015-09-01 23:53:38]

I think jln@ or mdempsky@ will be better reviewers for the files you asked me to
review. Please redirect it to them.

[Mark Seaborn, 2015-09-01 23:54:42]

On 2015/09/01 23:18:06, Greg Kerr wrote:
> mailto:mseaborn@chromium.org: Please review changes in 
> components/nacl/browser/nacl_process_host.cc

Sure, LGTM for that, it's a one-line whitespace change. :-)  Perhaps the result
of a merge?

[Greg K, 2015-09-01 23:59:16]

On 2015/09/01 23:54:42, Mark Seaborn wrote:
> On 2015/09/01 23:18:06, Greg Kerr wrote:
> > mailto:mseaborn@chromium.org: Please review changes in 
> > components/nacl/browser/nacl_process_host.cc
> 
> Sure, LGTM for that, it's a one-line whitespace change. :-)  Perhaps the
result
> of a merge?

Oh wow, I missed that. Indeed, it was the result of a merge and a rebase. I'll
just reset the file to current HEAD.

[Greg K, 2015-09-01 23:59:40]

kerrnel@chromium.org changed reviewers:
- nasko@chromium.org

[Greg K, 2015-09-02 00:01:09]

kerrnel@chromium.org changed reviewers:
+ jln@chromium.org, mdempsky@chromium.org

[Greg K, 2015-09-02 00:01:09]

Adding jln and mdempsky to review the files in content/ per nasko's requests

[mdempsky, 2015-09-02 21:33:05]

LGTM

Not sure why nasko suggested jln and I for this CL, since it's very OS X
specific (as opposed to Linux or generic POSIX).  However, it's pretty small and
makes perfect sense to me.

[Greg K, 2015-09-02 21:34:57]

kerrnel@chromium.org changed reviewers:
+ nasko@chromium.org

[Greg K, 2015-09-02 21:34:58]

nasko@chromium.org: Please review changes in 

Want to give the owner sign off now that mdempsky looked it over? Thanks!

[nasko, 2015-09-02 22:03:54]

Rubberstamp LGTM, base don mdempsky@'s review.

[Greg K, 2015-09-03 16:54:29]

The CQ bit was checked by kerrnel@chromium.org

[Greg K, 2015-09-03 16:54:30]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
mseaborn@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1315163004/#ps60001
(title: "Drop a one line whitespace change.")

[commit-bot: I haz the power, 2015-09-03 16:54:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315163004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315163004/60001

[commit-bot: I haz the power, 2015-09-03 20:53:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-03 20:53:56]

Patchset 4 (id:??) landed as
https://crrev.com/f5ed554ef814418d64510aa18b43b69315e40814
Cr-Commit-Position: refs/heads/master@{#347235}

[Nico, 2015-09-16 21:51:01]

I happened to see
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/tools/build...
today which still references the old helper names.

[Greg K, 2015-09-16 21:54:18]

On 2015/09/16 21:51:01, Nico wrote:
> I happened to see
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/tools/build...
> today which still references the old helper names.

That's a good catch, I'll address that in the next day or so.