Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 1315163004: Remove the unused helper apps on OS X. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Drop a one line whitespace change. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/mac/make_more_helpers.sh ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_main_delegate.cc
diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc
index 8b6457c202be4e75f20ef6d245d73b61bbf18646..ea84c54698f8425c3aabf408b1d38febd705ce4b 100644
--- a/chrome/app/chrome_main_delegate.cc
+++ b/chrome/app/chrome_main_delegate.cc
@@ -613,26 +613,6 @@ void ChromeMainDelegate::InitMacCrashReporter(
CHECK(command_line.HasSwitch(switches::kProcessType) &&
!process_type.empty())
<< "Helper application requires --type.";
-
- // In addition, some helper flavors only work with certain process types.
- base::FilePath executable;
- if (PathService::Get(base::FILE_EXE, &executable) &&
- executable.value().size() >= 3) {
- std::string last_three =
- executable.value().substr(executable.value().size() - 3);
-
- if (last_three == " EH") {
- CHECK(process_type == switches::kPluginProcess ||
- process_type == switches::kUtilityProcess)
- << "Executable-heap process requires --type="
- << switches::kPluginProcess << " or "
- << switches::kUtilityProcess << ", saw " << process_type;
- } else {
- CHECK(process_type != switches::kPluginProcess)
- << "Non-executable-heap PIE process is intolerant of --type="
- << switches::kPluginProcess;
- }
- }
} else {
CHECK(!command_line.HasSwitch(switches::kProcessType) &&
process_type.empty())
« no previous file with comments | « build/mac/make_more_helpers.sh ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698