Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 131513026: Inject default libraries to all targets in GN. (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Inject default libraries to all targets in GN. In GYP Mac, most targets got a default set of mac libraries by virtue of depending on base, which due to a GYP bug pushed the libraries to all targets depending on base, even separate shared libraries. In GYP Windows the set of default libraries on Windows is global and this keeps the same list and behavior. The lists of libraries could use some cleanup, btu this patch just attempts to keep the status quo in a cleaner way rather than fixing the unreasonable list of libraries (especially on Windows). R=scottmg@chromium.org, scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249600

Patch Set 1 #

Patch Set 2 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -65 lines) Patch
M base/BUILD.gn View 3 chunks +0 lines, -23 lines 0 comments Download
M build/config/BUILD.gn View 3 chunks +73 lines, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M build/config/win/BUILD.gn View 1 2 chunks +2 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
6 years, 10 months ago (2014-02-06 04:45:40 UTC) #1
scottmg
lgtm
6 years, 10 months ago (2014-02-06 16:48:47 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 10 months ago (2014-02-07 02:54:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/131513026/30001
6 years, 10 months ago (2014-02-07 02:54:39 UTC) #4
brettw
The CQ bit was unchecked by brettw@chromium.org
6 years, 10 months ago (2014-02-07 03:59:25 UTC) #5
brettw
6 years, 10 months ago (2014-02-07 04:00:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r249600 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698