Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: base/BUILD.gn

Issue 131513026: Inject default libraries to all targets in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: spelling Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 8e7471a5a2afd938324c7b393c3b183435b2a996..4413c7e7633f787a48b1b4fc6f6e356ad473680d 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -705,8 +705,6 @@ component("base") {
"//third_party/modp_b64",
]
- libs = []
-
if (!is_chromeos) {
sources -= [
"sys_info_chromeos.cc",
@@ -757,7 +755,6 @@ component("base") {
} else if (!is_nacl) {
# Non-Windows.
deps += [ "//third_party/libevent" ]
- libs += [ "dl" ]
}
# Mac.
@@ -768,31 +765,11 @@ component("base") {
"strings/sys_string_conversions_posix.cc",
]
deps += [ "//third_party/mach_override" ]
- libs += [
- "AppKit.framework",
- "ApplicationServices.framework",
- "Carbon.framework",
- "CoreFoundation.framework",
- "Foundation.framework",
- "IOKit.framework",
- "Security.framework",
- ]
} else {
# Non-Mac.
sources -= [ "files/file_path_watcher_kqueue.cc" ]
}
- # IOS.
- if (is_ios) {
- libs += [
- "CoreFoundation.framework",
- "CoreGraphics.framework",
- "CoreText.framework",
- "Foundation.framework",
- "UIKit.framework",
- ]
- }
-
# Linux.
if (is_linux) {
# TODO(brettw) these will need to be parameterized at some point.
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698