Add partitionsOutOfMemoryUsingXXX to know Blink memory usage from OOM crash reports

Add partitionsOutOfMemoryUsingXXX to know Blink memory usage from crash reports when PartitionAlloc hits OOM.

To avoid linker optimization, copied alias.cc and alias.h from //base/debug to WTF.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201791

[tasak, 2015-09-03 10:29:37]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[haraken, 2015-09-03 10:53:43]

https://codereview.chromium.org/1315113006/diff/1/Source/wtf/PartitionAlloc.cpp
File Source/wtf/PartitionAlloc.cpp (right):

https://codereview.chromium.org/1315113006/diff/1/Source/wtf/PartitionAlloc.c...
Source/wtf/PartitionAlloc.cpp:33: #include "wtf/Partitions.h"

We don't want to add this dependency -- PartitionAlloc should be standalone.

Shall we define the OOM-handling function in Partitions.h (or somewhere) and
pass in the function pointer to PartitionAlloc.h?

[tasak, 2015-09-04 05:17:03]

tasak@google.com changed reviewers:
+ tzik@chromium.org

[tasak, 2015-09-04 05:17:04]

https://codereview.chromium.org/1315113006/diff/1/Source/wtf/PartitionAlloc.cpp
File Source/wtf/PartitionAlloc.cpp (right):

https://codereview.chromium.org/1315113006/diff/1/Source/wtf/PartitionAlloc.c...
Source/wtf/PartitionAlloc.cpp:33: #include "wtf/Partitions.h"
On 2015/09/03 10:53:43, haraken wrote:
> 
> We don't want to add this dependency -- PartitionAlloc should be standalone.
> 
> Shall we define the OOM-handling function in Partitions.h (or somewhere) and
> pass in the function pointer to PartitionAlloc.h?

Done.

[haraken, 2015-09-04 05:22:45]

Add more rationale of the change to the CL description.

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.cpp
File Source/wtf/Alias.cpp (right):

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.cpp#ne...
Source/wtf/Alias.cpp:1: // Copyright (c) 2011 The Chromium Authors. All rights
reserved.

2015

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.h
File Source/wtf/Alias.h (right):

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.h#newc...
Source/wtf/Alias.h:1: // Copyright (c) 2011 The Chromium Authors. All rights
reserved.

2015

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.h#newc...
Source/wtf/Alias.h:13: // optimizing out variables that that would not otherwise
be live at the point

that that

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.h#newc...
Source/wtf/Alias.h:15: void WTF_EXPORT alias(const void* var);

Shall we add this to Compiler.h instead of introducing a new file?

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/PartitionAll...
File Source/wtf/PartitionAlloc.h (right):

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/PartitionAll...
Source/wtf/PartitionAlloc.h:322: static size_t (*gMemoryUsageReportFunction)();

Instead of exporting gMemoryUsageReportFunction, how about exporting
oomHandlingFunction? Then you can define oomHandlingFunction outside
PartitionAlloc and thus can do whatever you want. It would be more flexible.

[tasak, 2015-09-04 06:07:33]

Patchset #5 (id:80001) has been deleted

[tasak, 2015-09-04 06:08:05]

Patchset #4 (id:60001) has been deleted

[tasak, 2015-09-04 06:12:06]

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.cpp
File Source/wtf/Alias.cpp (right):

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.cpp#ne...
Source/wtf/Alias.cpp:1: // Copyright (c) 2011 The Chromium Authors. All rights
reserved.
On 2015/09/04 05:22:45, haraken wrote:
> 
> 2015

Since I copied //base/debug/alias.cc, I think, we should not modify copyright.

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.h
File Source/wtf/Alias.h (right):

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.h#newc...
Source/wtf/Alias.h:1: // Copyright (c) 2011 The Chromium Authors. All rights
reserved.
On 2015/09/04 05:22:45, haraken wrote:
> 
> 2015

Since I copied //base/debug/alias.h, I think, we should not modify copyright.

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.h#newc...
Source/wtf/Alias.h:13: // optimizing out variables that that would not otherwise
be live at the point
On 2015/09/04 05:22:45, haraken wrote:
> 
> that that

Done.

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/Alias.h#newc...
Source/wtf/Alias.h:15: void WTF_EXPORT alias(const void* var);
On 2015/09/04 05:22:45, haraken wrote:
> 
> Shall we add this to Compiler.h instead of introducing a new file?

So we will add Compiler.cpp?

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/PartitionAll...
File Source/wtf/PartitionAlloc.h (right):

https://codereview.chromium.org/1315113006/diff/40001/Source/wtf/PartitionAll...
Source/wtf/PartitionAlloc.h:322: static size_t (*gMemoryUsageReportFunction)();
On 2015/09/04 05:22:45, haraken wrote:
> 
> Instead of exporting gMemoryUsageReportFunction, how about exporting
> oomHandlingFunction? Then you can define oomHandlingFunction outside
> PartitionAlloc and thus can do whatever you want. It would be more flexible.
> 

Done.

[haraken, 2015-09-04 06:14:24]

LGTM

[haraken, 2015-09-04 06:14:49]

https://codereview.chromium.org/1315113006/diff/100001/Source/wtf/PartitionAl...
File Source/wtf/PartitionAlloc.h (right):

https://codereview.chromium.org/1315113006/diff/100001/Source/wtf/PartitionAl...
Source/wtf/PartitionAlloc.h:319: // gOomHandlingFunction is invoked when
ParitionAlloc says OutOfMemory.

when PartitionAlloc hits OOM

[tzik, 2015-09-04 06:23:51]

lgtm

[tasak, 2015-09-04 06:32:43]

Thank you for review.

https://codereview.chromium.org/1315113006/diff/100001/Source/wtf/PartitionAl...
File Source/wtf/PartitionAlloc.h (right):

https://codereview.chromium.org/1315113006/diff/100001/Source/wtf/PartitionAl...
Source/wtf/PartitionAlloc.h:319: // gOomHandlingFunction is invoked when
ParitionAlloc says OutOfMemory.
On 2015/09/04 06:14:48, haraken wrote:
> 
> when PartitionAlloc hits OOM

Done.

[tasak, 2015-09-04 06:32:45]

The CQ bit was checked by tasak@google.com

[tasak, 2015-09-04 06:32:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/1315113006/#ps120001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-09-04 06:32:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315113006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315113006/120001

[commit-bot: I haz the power, 2015-09-04 09:01:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 09:01:24]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tasak, 2015-09-04 09:13:29]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2015-09-04 09:13:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315113006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315113006/120001

[commit-bot: I haz the power, 2015-09-04 11:31:38]

Committed patchset #5 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201791