Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1315053004: Mac Overlays: Allow sandwich strategy to emit multiple overlays (Closed)

Created:
5 years, 3 months ago by ccameron
Modified:
5 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac Overlays: Allow sandwich strategy to emit multiple overlays Cut the region of the overlay candidate into rects and emit a quad and overlay for each rect. This helps with situations where there are logos or controls in the corners of a video (which then cause a huge top overlay). BUG=522627 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/09cc645bc3efbd964e2af2d5700413556edeaeed Cr-Commit-Position: refs/heads/master@{#346816}

Patch Set 1 #

Patch Set 2 : Use appropriate head #

Patch Set 3 : Remove false dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -19 lines) Patch
M cc/output/overlay_strategy_sandwich.cc View 2 chunks +35 lines, -19 lines 0 comments Download
M cc/output/overlay_unittest.cc View 3 chunks +68 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ccameron
More tweaks, ptal
5 years, 3 months ago (2015-09-01 01:44:49 UTC) #2
ccameron
ping
5 years, 3 months ago (2015-09-01 22:08:25 UTC) #3
alexst (slow to review)
On 2015/09/01 22:08:25, ccameron wrote: > ping woops, thanks for the ping, it slipped by. ...
5 years, 3 months ago (2015-09-01 22:32:12 UTC) #4
ccameron
Thanks!
5 years, 3 months ago (2015-09-01 23:47:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315053004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315053004/40001
5 years, 3 months ago (2015-09-01 23:49:52 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-02 01:27:58 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 01:28:43 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/09cc645bc3efbd964e2af2d5700413556edeaeed
Cr-Commit-Position: refs/heads/master@{#346816}

Powered by Google App Engine
This is Rietveld 408576698