Issue 131503015: Get rid of some uses of base::Create*Value

Issue 131503015: Get rid of some uses of base::Create*Value (Closed)

Created:
6 years, 10 months ago by Evan Stade

Modified:
6 years, 10 months ago

Reviewers:
Lei Zhang, Finnur, ajuma, Nico, Andrew T Wilson (Slow)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of some uses of base::Create*Value BUG=160586 TBR=finnur, ajuma, thakis, atwilson Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247922

Patch Set 1 #

Patch Set 2 : more #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -81 lines)			Patch
M	base/prefs/pref_registry_simple.cc	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	base/prefs/pref_service.cc	View	1	3 chunks	+6 lines, -8 lines	0 comments	Download
M	base/prefs/pref_service_unittest.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	base/values.cc	View	1	5 chunks	+19 lines, -19 lines	0 comments	Download
M	base/values_unittest.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	cc/resources/managed_tile_state.cc	View	1	1 chunk	+10 lines, -10 lines	0 comments	Download
M	cc/resources/raster_mode.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	cc/resources/tile_priority.cc	View	1	4 chunks	+16 lines, -21 lines	0 comments	Download
M	extensions/common/url_pattern_set.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	rlz/chromeos/lib/rlz_value_store_chromeos.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sync/syncable/entry_kernel.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

On 2014/01/29 01:57:08, Lei Zhang wrote: > lgtm, but I'm not an OWNER anywhere here. ...

6 years, 10 months ago (2014-01-29 01:57:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/131503015/20001

6 years, 10 months ago (2014-01-29 02:00:41 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217678

6 years, 10 months ago (2014-01-29 02:45:19 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/131503015/20001

6 years, 10 months ago (2014-01-29 22:28:33 UTC) #6

Message was sent while issue was closed.

Change committed as 247922

Expand Messages | Collapse Messages