Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3343)

Unified Diff: base/values_unittest.cc

Issue 131503015: Get rid of some uses of base::Create*Value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values.cc ('k') | cc/resources/managed_tile_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values_unittest.cc
diff --git a/base/values_unittest.cc b/base/values_unittest.cc
index 70acdfd6966aaf124b59e3b0b94640674bc0f489..c765deeb119f13cc78e48cddc5764c8ba24151f1 100644
--- a/base/values_unittest.cc
+++ b/base/values_unittest.cc
@@ -130,7 +130,7 @@ TEST(ValuesTest, BinaryValue) {
}
TEST(ValuesTest, StringValue) {
- // Test overloaded CreateStringValue.
+ // Test overloaded StringValue constructor.
scoped_ptr<Value> narrow_value(new StringValue("narrow"));
ASSERT_TRUE(narrow_value.get());
ASSERT_TRUE(narrow_value->IsType(Value::TYPE_STRING));
@@ -325,8 +325,8 @@ TEST(ValuesTest, DictionaryWithoutPathExpansion) {
TEST(ValuesTest, DictionaryRemovePath) {
DictionaryValue dict;
- dict.Set("a.long.way.down", Value::CreateIntegerValue(1));
- dict.Set("a.long.key.path", Value::CreateBooleanValue(true));
+ dict.Set("a.long.way.down", new FundamentalValue(1));
+ dict.Set("a.long.key.path", new FundamentalValue(true));
scoped_ptr<Value> removed_item;
EXPECT_TRUE(dict.RemovePath("a.long.way.down", &removed_item));
« no previous file with comments | « base/values.cc ('k') | cc/resources/managed_tile_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698