Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1314983004: Update args for the virtual/android/fullscreen layout test (Closed)

Created:
5 years, 3 months ago by watk
Modified:
5 years, 3 months ago
Reviewers:
philipj_slow
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update args for the virtual/android/fullscreen layout test Replace deprecated --enable-overlay-fullscreen-video with --force-overlay-fullscreen-video so that the former can be removed on the chromium side. BUG=511376 TEST=virtual/android/fullscreen layout tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/VirtualTestSuites View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
watk
Hi philipj, I forgot to update this flag in the previous CL https://codereview.chromium.org/1311763004
5 years, 3 months ago (2015-08-31 21:20:27 UTC) #2
philipj_slow
lgtm
5 years, 3 months ago (2015-09-01 08:50:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314983004/1
5 years, 3 months ago (2015-09-01 08:50:44 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 08:55:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201539

Powered by Google App Engine
This is Rietveld 408576698