Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311763004: Complete replacement of REF OverlayFullscreenVideo (Closed)

Created:
5 years, 3 months ago by watk
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, mlamouri+watch-blink_chromium.org, philipj_slow, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Complete replacement of REF OverlayFullscreenVideo Replace the runtime feature OverlayFullscreenVideo by ForceOverlayFullscreenVideo. A previous change allows WebMediaPlayer to decide whether to do overlay video, so this is no longer needed. The replacement allows the feature to be forced on for layout tests. BUG=511376 TEST=virtual/android/fullscreen layout tests, manual Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-allowed-video.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/video-controls-timeline.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/video-fail-to-enter-full-screen.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/video-specified-size.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
watk
Hi japhet@, please take a look
5 years, 3 months ago (2015-08-24 23:37:42 UTC) #2
philipj_slow
lgtm
5 years, 3 months ago (2015-08-25 07:23:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311763004/1
5 years, 3 months ago (2015-08-25 17:38:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104016)
5 years, 3 months ago (2015-08-25 18:46:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311763004/1
5 years, 3 months ago (2015-08-25 20:13:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104143)
5 years, 3 months ago (2015-08-25 21:31:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311763004/1
5 years, 3 months ago (2015-08-26 20:15:19 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 22:09:03 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201253

Powered by Google App Engine
This is Rietveld 408576698