Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1314953011: Revert of [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. (patchset #2 id:20001 of https://codereview.chromium.org/1328093006/ ) Reason for revert: somehow managed to break Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/30632/steps/telemetry_unittests/logs/stdio Original issue's description: > [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. > > BUG= > > Committed: https://crrev.com/e1bf30fc53406ba3bc1b302e87ecda6e3ad2025d > Cr-Commit-Position: refs/heads/master@{#347816} TBR=nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/02d09c5f8137a4ba1460e2c2a4400a8f128a75a5 Cr-Commit-Position: refs/heads/master@{#347837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M tools/telemetry/telemetry/core/exceptions.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/story_runner_unittest.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException.
5 years, 3 months ago (2015-09-08 23:51:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314953011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314953011/1
5 years, 3 months ago (2015-09-08 23:51:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 23:52:34 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 23:53:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02d09c5f8137a4ba1460e2c2a4400a8f128a75a5
Cr-Commit-Position: refs/heads/master@{#347837}

Powered by Google App Engine
This is Rietveld 408576698