tools/telemetry/telemetry/internal/story_runner_unittest.py - Issue 1314953011: Revert of [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/story_runner_unittest.py

Issue 1314953011: Revert of [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/internal/story_runner_unittest.py

diff --git a/tools/telemetry/telemetry/internal/story_runner_unittest.py b/tools/telemetry/telemetry/internal/story_runner_unittest.py

index e7f8b88a8865367bfaecfb3542f720028f7f0657..7ea3e1508e9a7ba7a89dcf07ae313247c2121f99 100644

--- a/tools/telemetry/telemetry/internal/story_runner_unittest.py

+++ b/tools/telemetry/telemetry/internal/story_runner_unittest.py

@@ -351,7 +351,7 @@

story_set = story_module.StorySet()

class SharedStoryThatCausesAppCrash(TestSharedPageState):

def WillRunStory(self, story):

- raise exceptions.AppCrashException(msg='App Foo crashes')

+ raise exceptions.AppCrashException('App Foo crashes')

story_set.AddStory(DummyLocalStory(

SharedStoryThatCausesAppCrash))

@@ -409,8 +409,7 @@

old_run_count = self.run_count

self.run_count += 1

if old_run_count == 0:

- raise exceptions.BrowserGoneException(

- None, 'i am a browser crash message')

+ raise exceptions.BrowserGoneException('i am a browser instance')

def ValidateAndMeasurePage(self, page, tab, results):

pass

« no previous file with comments | « tools/telemetry/telemetry/core/exceptions.py ('k') | no next file » | no next file with comments »