Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1314923007: Add support for MediaPermissionDispatcher to use other permission types. (Closed)

Created:
5 years, 3 months ago by guoweis_left_chromium
Modified:
5 years, 3 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for MediaPermissionDispatcher to use other permission types. MediaPermissionDispatcher becomes the common way for renderer process to query permission status through mojo services. BUG=520101 Committed: https://crrev.com/0323f04c1ddfb1d2a046dfed7a902c351e65180a Cr-Commit-Position: refs/heads/master@{#346797}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M content/renderer/media/media_permission_dispatcher.cc View 1 2 5 chunks +21 lines, -4 lines 0 comments Download
M media/base/media_permission.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
guoweis_left_chromium
PTAL.
5 years, 3 months ago (2015-08-28 00:08:22 UTC) #2
xhwang
Looking good % one nit. But let's get the naming right first. https://codereview.chromium.org/1314923007/diff/1/content/renderer/media/media_permission_dispatcher.cc File content/renderer/media/media_permission_dispatcher.cc ...
5 years, 3 months ago (2015-08-28 05:08:41 UTC) #3
guoweis_left_chromium
PTAL.
5 years, 3 months ago (2015-09-01 15:13:45 UTC) #4
guoweis_left_chromium
ddorwin@chromium.org: PTAL. This is based on https://codereview.chromium.org/1311783007/
5 years, 3 months ago (2015-09-01 19:45:55 UTC) #7
guoweis_left_chromium
David, Can you still look at this one since this is just a plain refatoring? ...
5 years, 3 months ago (2015-09-01 20:48:19 UTC) #10
ddorwin
lgtm
5 years, 3 months ago (2015-09-01 22:24:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923007/40001
5 years, 3 months ago (2015-09-01 23:21:09 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-02 00:25:44 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 00:26:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0323f04c1ddfb1d2a046dfed7a902c351e65180a
Cr-Commit-Position: refs/heads/master@{#346797}

Powered by Google App Engine
This is Rietveld 408576698