Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: content/renderer/media/media_permission_dispatcher.cc

Issue 1314923007: Add support for MediaPermissionDispatcher to use other permission types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/media_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_permission_dispatcher.cc
diff --git a/content/renderer/media/media_permission_dispatcher.cc b/content/renderer/media/media_permission_dispatcher.cc
index 7c08edd4ab883cb8867b7e17696d6502ef4ac2de..ad2c825506252f3d3dc5f6408e1ecfa26c57e962 100644
--- a/content/renderer/media/media_permission_dispatcher.cc
+++ b/content/renderer/media/media_permission_dispatcher.cc
@@ -11,6 +11,25 @@
#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
#include "url/gurl.h"
+namespace {
+
+using Type = media::MediaPermission::Type;
+
+content::PermissionName MediaPermissionTypeToPermissionName(Type type) {
+ switch (type) {
+ case Type::PROTECTED_MEDIA_IDENTIFIER:
+ return content::PERMISSION_NAME_PROTECTED_MEDIA_IDENTIFIER;
+ case Type::AUDIO_CAPTURE:
+ return content::PERMISSION_NAME_AUDIO_CAPTURE;
+ case Type::VIDEO_CAPTURE:
+ return content::PERMISSION_NAME_VIDEO_CAPTURE;
+ }
+ NOTREACHED();
+ return content::PERMISSION_NAME_PROTECTED_MEDIA_IDENTIFIER;
+}
+
+} // namespace
+
namespace content {
MediaPermissionDispatcher::MediaPermissionDispatcher(RenderFrame* render_frame)
@@ -32,7 +51,6 @@ void MediaPermissionDispatcher::HasPermission(
const GURL& security_origin,
const PermissionStatusCB& permission_status_cb) {
DCHECK(thread_checker_.CalledOnValidThread());
- CHECK_EQ(PROTECTED_MEDIA_IDENTIFIER, type);
if (!permission_service_.get()) {
render_frame()->GetServiceRegistry()->ConnectToRemoteService(
@@ -46,7 +64,7 @@ void MediaPermissionDispatcher::HasPermission(
DVLOG(2) << __FUNCTION__ << ": request ID " << request_id;
permission_service_->HasPermission(
- PERMISSION_NAME_PROTECTED_MEDIA_IDENTIFIER, security_origin.spec(),
+ MediaPermissionTypeToPermissionName(type), security_origin.spec(),
base::Bind(&MediaPermissionDispatcher::OnPermissionStatus,
base::Unretained(this), request_id));
}
@@ -56,7 +74,6 @@ void MediaPermissionDispatcher::RequestPermission(
const GURL& security_origin,
const PermissionStatusCB& permission_status_cb) {
DCHECK(thread_checker_.CalledOnValidThread());
- CHECK_EQ(PROTECTED_MEDIA_IDENTIFIER, type);
if (!permission_service_.get()) {
render_frame()->GetServiceRegistry()->ConnectToRemoteService(
@@ -70,7 +87,7 @@ void MediaPermissionDispatcher::RequestPermission(
DVLOG(2) << __FUNCTION__ << ": request ID " << request_id;
permission_service_->RequestPermission(
- PERMISSION_NAME_PROTECTED_MEDIA_IDENTIFIER, security_origin.spec(),
+ MediaPermissionTypeToPermissionName(type), security_origin.spec(),
blink::WebUserGestureIndicator::isProcessingUserGesture(),
base::Bind(&MediaPermissionDispatcher::OnPermissionStatus,
base::Unretained(this), request_id));
« no previous file with comments | « no previous file | media/base/media_permission.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698