chrome/browser/sync/profile_sync_service.h - Issue 1314903004: Sync: Refactoring DataTypeController to make the design shareable with USS datatypes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 1314903004: Sync: Refactoring DataTypeController to make the design shareable with USS datatypes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing build on Android Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory_impl.h ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | chrome/browser/sync/profile_sync_service_autofill_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service.h

diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h

index b57387a6bdf34d2420e0689220a4bbbd88d50efd..26b41bcedddbda698adda2c67a660bd8f2c7c9b2 100644

--- a/chrome/browser/sync/profile_sync_service.h

+++ b/chrome/browser/sync/profile_sync_service.h

@@ -338,6 +338,7 @@ class ProfileSyncService : public sync_driver::SyncService,

// ProfileSyncService. It declares that this sync type may be activated at

// some point in the future. This function call does not enable or activate

// the syncing of this type

+ // TODO: this should merge with RegisterDataTypeController

stanisc 2015/09/02 17:27:05 Will address this in the next patch. Let me know i

Nicolas Zea 2015/09/02 22:52:45 You can leave this, but it would be good to mark y

stanisc 2015/09/03 01:17:42 Done.

void RegisterNonBlockingType(syncer::ModelType type);

// Called by a component that supports non-blocking sync when it is ready to

@@ -347,6 +348,7 @@ class ProfileSyncService : public sync_driver::SyncService,

// should result in a message to enable syncing for this type when the sync

// backend is available. If the type is not to be synced, this should result

// in a message that allows the component to delete its local sync state.

+ // TODO: review usage of this

void InitializeNonBlockingType(

syncer::ModelType type,

const scoped_refptr<base::SequencedTaskRunner>& task_runner,