Sync: Refactoring DataTypeController to make the design shareable with USS datatypes.

chrome/browser/sync/profile_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 320 matching lines @@
   void UnregisterAuthNotifications();
 
   // Return whether OAuth2 refresh token is loaded and available for the backend
   // to start up. Virtual to enable mocking in tests.
   virtual bool IsOAuthRefreshTokenAvailable();
 
   // Registers a type whose sync storage will not be managed by the
   // ProfileSyncService.  It declares that this sync type may be activated at
   // some point in the future.  This function call does not enable or activate
   // the syncing of this type
+  // TODO: this should merge with RegisterDataTypeController

[stanisc, 2015/09/02 17:27:05]

Will address this in the next patch. Let me know if I should remove this from
this patch.

[Nicolas Zea, 2015/09/02 22:52:45]

You can leave this, but it would be good to mark yourself as the owner and
mention a bug. TODO(stanisc) crbug.com/xxx ...

[stanisc, 2015/09/03 01:17:42]

Done.

   void RegisterNonBlockingType(syncer::ModelType type);
 
   // Called by a component that supports non-blocking sync when it is ready to
   // initialize its connection to the sync backend.
   //
   // If policy allows for syncing this type (ie. it is "preferred"), then this
   // should result in a message to enable syncing for this type when the sync
   // backend is available.  If the type is not to be synced, this should result
   // in a message that allows the component to delete its local sync state.
+  // TODO: review usage of this
   void InitializeNonBlockingType(
       syncer::ModelType type,
       const scoped_refptr<base::SequencedTaskRunner>& task_runner,
       const base::WeakPtr<syncer_v2::ModelTypeSyncProxyImpl>& proxy);
 
   // Returns the SyncedWindowDelegatesGetter from the embedded sessions manager.
   virtual browser_sync::SyncedWindowDelegatesGetter*
   GetSyncedWindowDelegatesGetter() const;
 
   // Returns the SyncableService for syncer::SESSIONS.
@@ skipping 681 matching lines @@
   base::WeakPtrFactory<ProfileSyncService> startup_controller_weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(
     const syncer::SyncProtocolError& error);
 
 
 #endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_