Updating of all entries in PasswordManager of the same credentials on password update

chrome/browser/password_manager/native_backend_libsecret.cc

Index: chrome/browser/password_manager/native_backend_libsecret.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc
index fdd95a3ad4be3a8a5ebdb117df11628e8b83bce8..000040f3d4d641ed4d12d13167e5054659d2ba43 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret.cc
@@ -616,7 +616,6 @@ ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::ConvertFormList(
         psl_domain_match_metric = password_manager::PSL_DOMAIN_MATCH_FOUND;
         form->original_signon_realm = form->signon_realm;
         form->signon_realm = lookup_form->signon_realm;
-        form->origin = lookup_form->origin;

[vabr (Chromium), 2015/08/28 10:47:23]

Do you remove this to be able to update it correctly later? Does it influence
the scoring for the PSL matches?

[dvadym, 2015/08/28 11:25:28]

Good point, it influences PSL scoring, but current algo for scoring PSL matching
is very strange. For PSL matching forms candidate.origin ==
observed_form_.origin (here
https://code.google.com/p/chromium/codesearch#chromium/src/components/passwor...)
and so everything after / is not taken into consideration. So leaving origin as
in stored form seems to be event better, but we need to add some votes for PSL
matching in order not to get 0 result. What do you think?

[vabr (Chromium), 2015/08/28 11:38:41]

Yes, it is fine to adapt the scoring, but we should make sure that the result is
not too different from what it is now.

       }
       SecretValue* secretValue = secret_item_get_secret(secretItem);
       if (secretValue) {