Updating of all entries in PasswordManager of the same credentials on password update

chrome/browser/password_manager/native_backend_libsecret.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/native_backend_libsecret.h"
 
 #include <dlfcn.h>
 #include <list>
 
 #include "base/basictypes.h"
@@ skipping 598 matching lines @@
         // This is not an exact match, we try PSL matching.
         if (lookup_form->scheme != PasswordForm::SCHEME_HTML ||
             form->scheme != PasswordForm::SCHEME_HTML ||
             !(password_manager::IsPublicSuffixDomainMatch(
                 lookup_form->signon_realm, form->signon_realm))) {
           continue;
         }
         psl_domain_match_metric = password_manager::PSL_DOMAIN_MATCH_FOUND;
         form->original_signon_realm = form->signon_realm;
         form->signon_realm = lookup_form->signon_realm;
-        form->origin = lookup_form->origin;

[vabr (Chromium), 2015/08/28 10:47:23]

Do you remove this to be able to update it correctly later? Does it influence
the scoring for the PSL matches?

[dvadym, 2015/08/28 11:25:28]

Good point, it influences PSL scoring, but current algo for scoring PSL matching
is very strange. For PSL matching forms candidate.origin ==
observed_form_.origin (here
https://code.google.com/p/chromium/codesearch#chromium/src/components/passwor...)
and so everything after / is not taken into consideration. So leaving origin as
in stored form seems to be event better, but we need to add some votes for PSL
matching in order not to get 0 result. What do you think?

[vabr (Chromium), 2015/08/28 11:38:41]

Yes, it is fine to adapt the scoring, but we should make sure that the result is
not too different from what it is now.

       }
       SecretValue* secretValue = secret_item_get_secret(secretItem);
       if (secretValue) {
         form->password_value = UTF8ToUTF16(secret_value_get_text(secretValue));
         secret_value_unref(secretValue);
       } else {
         LOG(WARNING) << "Unable to access password from list element!";
       }
       forms.push_back(form.Pass());
     } else {
       VLOG(1) << "Could not initialize PasswordForm from attributes!";
     }
   }
 
   if (lookup_form) {
     const GURL signon_realm(lookup_form->signon_realm);
     std::string registered_domain =
         password_manager::GetRegistryControlledDomain(signon_realm);
     UMA_HISTOGRAM_ENUMERATION(
         "PasswordManager.PslDomainMatchTriggering",
         password_manager::ShouldPSLDomainMatchingApply(registered_domain)
             ? psl_domain_match_metric
             : password_manager::PSL_DOMAIN_MATCH_NOT_USED,
         password_manager::PSL_DOMAIN_MATCH_COUNT);
   }
   g_list_free(found);
   return forms.Pass();
 }