Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bot fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
index 6b5c21d00e61d0d98c9a601bee9c17a77fe74c4c..759ba3f387a0da0734dab57cb5b4b9659be8df11 100644
--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
@@ -464,8 +464,8 @@ class NativeBackendLibsecretTest : public testing::Test {
EXPECT_EQ(1u, form_list.size());
PasswordForm m_facebook = *form_list[0];
form_list.clear();
- EXPECT_EQ(kMobileURL, m_facebook.origin);
- EXPECT_EQ(kMobileURL.spec(), m_facebook.signon_realm);
+ m_facebook.origin = kMobileURL;
+ m_facebook.signon_realm = kMobileURL.spec();
// Add the PSL-matched copy to saved logins.
VerifiedAdd(&backend, m_facebook);
@@ -495,7 +495,7 @@ class NativeBackendLibsecretTest : public testing::Test {
// There should be two results -- the exact one, and the PSL-matched one.
EXPECT_EQ(2u, form_list.size());
size_t index_non_psl = 0;
- if (!form_list[index_non_psl]->original_signon_realm.empty())
+ if (form_list[index_non_psl]->is_public_suffix_match)
index_non_psl = 1;
EXPECT_EQ(kMobileURL, form_list[index_non_psl]->origin);
EXPECT_EQ(kMobileURL.spec(), form_list[index_non_psl]->signon_realm);
@@ -507,7 +507,7 @@ class NativeBackendLibsecretTest : public testing::Test {
// There should be two results -- the exact one, and the PSL-matched one.
EXPECT_EQ(2u, form_list.size());
index_non_psl = 0;
- if (!form_list[index_non_psl]->original_signon_realm.empty())
+ if (form_list[index_non_psl]->is_public_suffix_match)
index_non_psl = 1;
EXPECT_EQ(form_facebook_.origin, form_list[index_non_psl]->origin);
EXPECT_EQ(form_facebook_.signon_realm,
@@ -632,8 +632,8 @@ TEST_F(NativeBackendLibsecretTest, PSLMatchingPositive) {
const GURL kMobileURL("http://m.facebook.com/");
EXPECT_TRUE(CheckCredentialAvailability(form_facebook_, kMobileURL,
PasswordForm::SCHEME_HTML, &result));
- EXPECT_EQ(kMobileURL, result.origin);
- EXPECT_EQ(kMobileURL.spec(), result.signon_realm);
+ EXPECT_EQ(form_facebook_.origin, result.origin);
+ EXPECT_EQ(form_facebook_.signon_realm, result.signon_realm);
}
// Save a password for www.facebook.com and see it not suggested for
« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698