chrome/browser/password_manager/native_backend_libsecret.cc - Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bot fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_gnome_x_unittest.cc ('k') | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc

index fdd95a3ad4be3a8a5ebdb117df11628e8b83bce8..a0d81ef03c2df90b2954871c90e512ebf123fff7 100644

--- a/chrome/browser/password_manager/native_backend_libsecret.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret.cc

@@ -614,9 +614,7 @@ ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::ConvertFormList(

continue;

}

psl_domain_match_metric = password_manager::PSL_DOMAIN_MATCH_FOUND;

- form->original_signon_realm = form->signon_realm;

- form->signon_realm = lookup_form->signon_realm;

- form->origin = lookup_form->origin;

+ form->is_public_suffix_match = true;

}

SecretValue* secretValue = secret_item_get_secret(secretItem);

if (secretValue) {