components/password_manager/core/browser/login_database_unittest.cc - Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Vasilii comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/save_password_progress_logger.cc ('K') | « components/password_manager/core/browser/login_database.cc ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database_unittest.cc

diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc

index 2868f813196ee138e32763b58271f18018bebe5b..7faa7f6fd221026db4d41153d3c06a60892ce32f 100644

--- a/components/password_manager/core/browser/login_database_unittest.cc

+++ b/components/password_manager/core/browser/login_database_unittest.cc

@@ -339,8 +339,8 @@ TEST_F(LoginDatabaseTest, TestPublicSuffixDomainMatching) {

// Match against the mobile site.

EXPECT_TRUE(db().GetLogins(form2, &result));

EXPECT_EQ(1U, result.size());

- EXPECT_EQ("https://mobile.foo.com/", result[0]->signon_realm);

- EXPECT_EQ("https://foo.com/", result[0]->original_signon_realm);

+ EXPECT_EQ("https://foo.com/", result[0]->signon_realm);

+ EXPECT_TRUE(result[0]->is_public_suffix_match);

// Try to remove PSL matched form

EXPECT_FALSE(db().RemoveLogin(*result[0]));

@@ -461,8 +461,8 @@ TEST_F(LoginDatabaseTest, TestPublicSuffixDomainMatchingDifferentSites) {

// Match against the mobile site.

EXPECT_TRUE(db().GetLogins(form2, &result));

EXPECT_EQ(1U, result.size());

- EXPECT_EQ("https://mobile.foo.com/", result[0]->signon_realm);

- EXPECT_EQ("https://foo.com/", result[0]->original_signon_realm);

+ EXPECT_EQ("https://foo.com/", result[0]->signon_realm);

+ EXPECT_TRUE(result[0]->is_public_suffix_match);

result.clear();

// Add baz.com desktop site.

@@ -493,8 +493,8 @@ TEST_F(LoginDatabaseTest, TestPublicSuffixDomainMatchingDifferentSites) {

// Match against the mobile site of baz.com.

EXPECT_TRUE(db().GetLogins(form3, &result));

EXPECT_EQ(1U, result.size());

- EXPECT_EQ("https://m.baz.com/", result[0]->signon_realm);

- EXPECT_EQ("https://baz.com/", result[0]->original_signon_realm);

+ EXPECT_EQ("https://baz.com/", result[0]->signon_realm);

+ EXPECT_TRUE(result[0]->is_public_suffix_match);

result.clear();

}