components/autofill/core/common/save_password_progress_logger.cc - Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Vasilii comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/password_form_fill_data_unittest.cc ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/core/browser/affiliated_match_helper.h » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index c7c51ccceb56cfed3cfa274b271db37b07d9b084..37763c28f028fee58c33d17c71afe823ed3d3423 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -80,8 +80,8 @@ void SavePasswordProgressLogger::LogPasswordForm(

GetStringFromID(FormSchemeToStringID(form.scheme)));

log.SetString(GetStringFromID(STRING_SIGNON_REALM),

ScrubURL(GURL(form.signon_realm)));

- log.SetString(GetStringFromID(STRING_ORIGINAL_SIGNON_REALM),

- ScrubURL(GURL(form.original_signon_realm)));

+ log.SetBoolean(GetStringFromID(STRING_IS_PUBLIC_SUFFIX_MATCH),

engedy 2015/09/29 16:20:45 Is there a reason to output the value of |form.is_

dvadym 2015/09/29 18:29:36 Thanks, it's left after refactoring.

+ form.is_public_suffix_match);

log.SetString(GetStringFromID(STRING_ORIGIN), ScrubURL(form.origin));

log.SetString(GetStringFromID(STRING_ACTION), ScrubURL(form.action));

log.SetString(GetStringFromID(STRING_USERNAME_ELEMENT),

@@ -94,7 +94,8 @@ void SavePasswordProgressLogger::LogPasswordForm(

log.SetBoolean(GetStringFromID(STRING_PASSWORD_GENERATED),

form.type == PasswordForm::TYPE_GENERATED);

log.SetInteger(GetStringFromID(STRING_TIMES_USED), form.times_used);

- log.SetBoolean(GetStringFromID(STRING_PSL_MATCH), form.IsPublicSuffixMatch());

+ log.SetBoolean(GetStringFromID(STRING_PSL_MATCH),

+ form.is_public_suffix_match);

LogValue(label, log);

}

@@ -184,8 +185,8 @@ std::string SavePasswordProgressLogger::GetStringFromID(

return "Scheme";

case SavePasswordProgressLogger::STRING_SIGNON_REALM:

return "Signon realm";

- case SavePasswordProgressLogger::STRING_ORIGINAL_SIGNON_REALM:

- return "Original signon realm";

+ case SavePasswordProgressLogger::STRING_IS_PUBLIC_SUFFIX_MATCH:

+ return "Is public suffix match";

case SavePasswordProgressLogger::STRING_ORIGIN:

return "Origin";

case SavePasswordProgressLogger::STRING_ACTION: