Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Vasilii comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc
diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc
index 23ffc12060321266e389ee994ebf894e55b479b6..6223ffcbd3f2b5308e28b1e31de3055c151ce120 100644
--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc
+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc
@@ -69,13 +69,9 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(
// TODO(mkwst): This doesn't create a PasswordForm that we can use to create
// a FederatedCredential (via CreatePasswordFormFromCredentialInfo). We need
// to fix that.
- ScopedVector<autofill::PasswordForm> more_local_results(
- AffiliatedMatchHelper::TransformAffiliatedAndroidCredentials(
- delegate_->GetSynthesizedFormForOrigin(),
- affiliated_results.Pass()));
- local_results.insert(local_results.end(), more_local_results.begin(),
- more_local_results.end());
- more_local_results.weak_clear();
+ local_results.insert(local_results.end(), affiliated_results.begin(),
+ affiliated_results.end());
+ affiliated_results.weak_clear();
}
if ((local_results.empty() && federated_results.empty())) {

Powered by Google App Engine
This is Rietveld 408576698