Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1314863006: Port SkBlitRow::Color32 to SkOpts. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
djsollen, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Port SkBlitRow::Color32 to SkOpts. This was a pre-SkOpts attempt that we can bring under its wing now. This should be a perf no-op, deo volente. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/4a37d08382a16717cde52c3d2687b021c5413464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -52 lines) Patch
M include/core/SkBlitRow.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkBlitRow_D32.cpp View 2 chunks +2 lines, -23 lines 0 comments Download
M src/core/SkOpts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkOpts.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
A src/opts/SkBlitRow_opts.h View 1 chunk +35 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M src/opts/SkBlitRow_opts_none.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkOpts_neon.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314863006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314863006/1
5 years, 3 months ago (2015-09-10 00:57:36 UTC) #2
mtklein_C
5 years, 3 months ago (2015-09-10 01:00:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-10 01:02:33 UTC) #6
reed1
lgtm
5 years, 3 months ago (2015-09-10 16:56:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314863006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314863006/1
5 years, 3 months ago (2015-09-10 17:37:37 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 17:38:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4a37d08382a16717cde52c3d2687b021c5413464

Powered by Google App Engine
This is Rietveld 408576698