Issue 131483008: Correctly report TypeError for HTML{Meter,Progress}Element setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131483008: Correctly report TypeError for HTML{Meter,Progress}Element setters. (Closed)

Created:
6 years, 10 months ago by sof

Modified:
6 years, 10 months ago

Reviewers:
arv (Not doing code reviews), Mike West

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Correctly report TypeError for HTML{Meter,Progress}Element setters. For the IDL attributes with a 'double' type on <meter> and <progress>, throw the WebIDL-required TypeError if the value being set isn't finite, http://heycam.github.io/webidl/#es-double Reporting TypeError rather than NotSupportedError also aligns with Gecko. (Trident doesn't throw.) R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165959

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -28 lines)			Patch
M	LayoutTests/fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLMeterElement.cpp	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLProgressElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sof

When you next have a spare moment, please take a look. There are some other ...

6 years, 10 months ago (2014-01-28 16:59:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/131483008/1

6 years, 10 months ago (2014-01-28 18:24:05 UTC) #3

Message was sent while issue was closed.

Change committed as 165959

Expand Messages | Collapse Messages