LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js - Issue 131483008: Correctly report TypeError for HTML{Meter,Progress}Element setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js

Issue 131483008: Correctly report TypeError for HTML{Meter,Progress}Element setters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt ('k') | LayoutTests/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js

diff --git a/LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js b/LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js

index 859f97bda8f8de6e66c6b875b4fd35a868318650..f1a4275cea2de5a2ccc88940c0b218e4a5f22460 100644

--- a/LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js

+++ b/LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js

@@ -27,16 +27,16 @@ shouldBe('p.value', '0');

shouldBe('p.position', '0');

debug("Set invalid value, should throw");

-shouldThrow('p.value = "200A";', '"NotSupportedError: Failed to set the \'value\' property on \'HTMLProgressElement\': The value provided is not a number."');

+shouldThrow('p.value = "200A";', '"TypeError: Failed to set the \'value\' property on \'HTMLProgressElement\': The value provided is not a number."');

debug("Set invalid max, should throw");

-shouldThrow('p.max = "max";', '"NotSupportedError: Failed to set the \'max\' property on \'HTMLProgressElement\': The value provided is not a number."');

+shouldThrow('p.max = "max";', '"TypeError: Failed to set the \'max\' property on \'HTMLProgressElement\': The value provided is not a number."');

debug("Set max to Infinity, should throw");

-shouldThrow('p.max = Infinity;', '"NotSupportedError: Failed to set the \'max\' property on \'HTMLProgressElement\': The value provided is infinite."');

+shouldThrow('p.max = Infinity;', '"TypeError: Failed to set the \'max\' property on \'HTMLProgressElement\': The value provided is infinite."');

debug("Set value to NaN, should throw");

-shouldThrow('p.value = NaN;', '"NotSupportedError: Failed to set the \'value\' property on \'HTMLProgressElement\': The value provided is not a number."');

+shouldThrow('p.value = NaN;', '"TypeError: Failed to set the \'value\' property on \'HTMLProgressElement\': The value provided is not a number."');

debug("Set value to null and max to 0");

p.value = null;