Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1314823011: [Android] Don't use a device blacklist if one isn't provided. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Don't use a device blacklist if one isn't provided. BUG=517709 Committed: https://crrev.com/be5c91849d2196f97c7a4e0b3e90597c3f2b4c40 Cr-Commit-Position: refs/heads/master@{#347473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -72 lines) Patch
M build/android/adb_install_apk.py View 1 chunk +3 lines, -6 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 1 chunk +3 lines, -5 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 1 chunk +3 lines, -5 lines 0 comments Download
M build/android/devil/android/device_blacklist.py View 2 chunks +5 lines, -22 lines 0 comments Download
M build/android/devil/android/device_utils.py View 1 chunk +1 line, -5 lines 0 comments Download
M build/android/enable_asserts.py View 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/provision_devices.py View 1 chunk +3 lines, -5 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 1 chunk +3 lines, -2 lines 0 comments Download
M build/android/screenshot.py View 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +3 lines, -6 lines 0 comments Download
M build/android/tombstones.py View 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/update_verification.py View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jbudorick
5 years, 3 months ago (2015-09-04 16:58:18 UTC) #2
rnephew (Reviews Here)
On 2015/09/04 16:58:18, jbudorick wrote: lgtm
5 years, 3 months ago (2015-09-04 17:04:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314823011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314823011/1
5 years, 3 months ago (2015-09-04 17:12:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 19:46:32 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/be5c91849d2196f97c7a4e0b3e90597c3f2b4c40 Cr-Commit-Position: refs/heads/master@{#347473}
5 years, 3 months ago (2015-09-04 19:47:15 UTC) #7
RobertoCN
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1306653005/ by robertocn@chromium.org. ...
5 years, 3 months ago (2015-09-04 21:18:19 UTC) #8
jbudorick
On 2015/09/04 at 21:18:19, robertocn wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 3 months ago (2015-09-04 21:22:46 UTC) #9
nednguyen
5 years, 3 months ago (2015-09-10 17:25:06 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1329343004/ by nednguyen@google.com.

The reason for reverting is: Suspect causing build failure (provision_devices
step)

BUG=530242.

Powered by Google App Engine
This is Rietveld 408576698