Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3252)

Unified Diff: build/android/devil/android/device_utils.py

Issue 1314823011: [Android] Don't use a device blacklist if one isn't provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/devil/android/device_blacklist.py ('k') | build/android/enable_asserts.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/devil/android/device_utils.py
diff --git a/build/android/devil/android/device_utils.py b/build/android/devil/android/device_utils.py
index c35bc264ef9e48da1cfbcb10aa4df75fbaf2c42f..ce653cdbd4f42cf5c6e3617c108356b5fa3f5547 100644
--- a/build/android/devil/android/device_utils.py
+++ b/build/android/devil/android/device_utils.py
@@ -1913,11 +1913,7 @@ class DeviceUtils(object):
@classmethod
def HealthyDevices(cls, blacklist=None, **kwargs):
- if not blacklist:
- # TODO(jbudorick): Remove once clients pass in the blacklist.
- blacklist = device_blacklist.Blacklist(device_blacklist.BLACKLIST_JSON)
-
- blacklisted_devices = blacklist.Read()
+ blacklisted_devices = blacklist.Read() if blacklist else []
def blacklisted(adb):
if adb.GetDeviceSerial() in blacklisted_devices:
logging.warning('Device %s is blacklisted.', adb.GetDeviceSerial())
« no previous file with comments | « build/android/devil/android/device_blacklist.py ('k') | build/android/enable_asserts.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698