V8 Buildbot: Fix strange bug with step names.

V8 Buildbot: Fix strange bug with step names.

BUG=v8:4408
TBR=tandrii@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296566

[Michael Achenbach, 2015-09-04 14:32:01]

machenbach@chromium.org changed reviewers:
+ hablich@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2015-09-04 14:34:22]

PTAL. Without this "fix" the recipe runs into this strange error:
http://build.chromium.org/p/client.v8.branches/builders/Auto-tag/builds/0/ste...

Reproduces also locally. With the fix it works.

CC'ed some recipe folks. Maybe someone wants to fix this in the recipe engine
upstream?

[Michael Hablich, 2015-09-04 14:44:53]

On 2015/09/04 14:34:22, Michael Achenbach wrote:
> PTAL. Without this "fix" the recipe runs into this strange error:
>
http://build.chromium.org/p/client.v8.branches/builders/Auto-tag/builds/0/ste...
> 
> Reproduces also locally. With the fix it works.
> 
> CC'ed some recipe folks. Maybe someone wants to fix this in the recipe engine
> upstream?

lgtm ... I love dynamic types ... *sigh*

[Michael Achenbach, 2015-09-04 14:49:30]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-09-04 14:49:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314823010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314823010/1

[commit-bot: I haz the power, 2015-09-04 14:52:04]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296566

[luqui, 2015-09-04 20:34:46]

On 2015/09/04 at 14:52:04, commit-bot wrote:
> Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296566

unicoOOOOODDDDDDDEEEEEEEEEEEEE!

[luqui, 2015-09-04 20:38:33]

On 2015/09/04 at 20:34:46, luqui wrote:
> On 2015/09/04 at 14:52:04, commit-bot wrote:
> > Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296566
> 
> unicoOOOOODDDDDDDEEEEEEEEEEEEE!

FWIW, recipe_moculdes/step/config.py says

# For compatibility with buildbot, the step name ust be ascii, which is why
# this is a 'str' and not a 'basestring'.
name = Single(str),

So it looks intentional.  The trouble is that we didn't simulate it as a unicode
string.  Maybe we should make it so all mock command outputs come in as
unicode?...  I don't know